Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComputeImageExtremaFilter SameGeometry should include Index, Spacing, and Direction #1023

Closed
N-Dekker opened this issue Jan 22, 2024 · 1 comment · Fixed by #1024
Closed

ComputeImageExtremaFilter SameGeometry should include Index, Spacing, and Direction #1023

N-Dekker opened this issue Jan 22, 2024 · 1 comment · Fixed by #1024

Comments

@N-Dekker
Copy link
Member

The ComputeImageExtremaFilter::SameGeometry() (which is used to optimize ThreadedGenerateDataImageSpatialMask) now only takes Size and Origin into account, when comparing the input image and the mask:

elastix/Common/itkComputeImageExtremaFilter.hxx

Lines 57 to 65 in 217a07c

ComputeImageExtremaFilter<TInputImage>::SameGeometry()
{
if (this->GetInput()->GetLargestPossibleRegion().GetSize() ==
this->m_ImageSpatialMask->GetImage()->GetLargestPossibleRegion().GetSize() &&
this->GetInput()->GetOrigin() == this->m_ImageSpatialMask->GetImage()->GetOrigin())
{
this->m_SameGeometry = true;
}
}

It should also include Index, Spacing, and Direction. As discussed at our internal weekly sprint meeting, with @stefanklein and @mstaring
@N-Dekker N-Dekker mentioned this issue Jan 22, 2024
Merged
N-Dekker added a commit that referenced this issue Jan 23, 2024
@N-Dekker
ENH: Test ComputeImageExtremaFilter.MaskSpacingAndDirectionAffectResults
888ae49 
Tests that changes of Spacing or Direction of the mask may affect the results of ComputeImageExtremaFilter.

Supports issue #1023 "ComputeImageExtremaFilter SameGeometry should include Index, Spacing, and Direction"
N-Dekker added a commit that referenced this issue Jan 23, 2024
@N-Dekker
ENH: Test ComputeImageExtremaFilter.MaskSpacingAndDirectionAffectResults
b54f5b9 
Tests that changes of Spacing or Direction of the mask may affect the results of ComputeImageExtremaFilter.

Supports issue #1023 "ComputeImageExtremaFilter SameGeometry should include Index, Spacing, and Direction"
N-Dekker added a commit that referenced this issue Jan 23, 2024
@N-Dekker
BUG: ComputeImageExtremaFilter SameGeometry include Spacing, Direction
47d2242 
Fixes issue #1023 "ComputeImageExtremaFilter SameGeometry should include Index, Spacing, and Direction"

Tested that changes of Spacing or Direction of the mask may indeed affect the results of ComputeImageExtremaFilter.
@N-Dekker N-Dekker mentioned this issue Jan 23, 2024
Merged
N-Dekker added a commit that referenced this issue Jan 27, 2024
@N-Dekker
BUG: ComputeImageExtremaFilter SameGeometry include Spacing, Direction
026075e 
Fixes issue #1023 "ComputeImageExtremaFilter SameGeometry should include Index, Spacing, and Direction"

Tested that changes of Spacing or Direction of the mask may indeed affect the results of ComputeImageExtremaFilter.
N-Dekker added a commit that referenced this issue Jan 29, 2024
@N-Dekker
BUG: ComputeImageExtremaFilter SameGeometry include Spacing, Direction
a53d49d 
Fixes issue #1023 "ComputeImageExtremaFilter SameGeometry should include Index, Spacing, and Direction"

Tested that changes of Spacing or Direction of the mask may indeed affect the results of ComputeImageExtremaFilter.
@N-Dekker N-Dekker linked a pull request Jan 30, 2024 that will close this issue
BUG: ComputeImageExtremaFilter SameGeometry include Spacing, Direction #1024
Merged
@N-Dekker
Copy link
Member Author

Fixed by pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: ComputeImageExtremaFilter SameGeometry include Spacing, Direction SuperElastix/elastix
1 participant
@N-Dekker