Call FastEvaluateMovingImageValueAndDerivative in six more metrics
#558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `this->EvaluateMovingImageValueAndDerivative(...)` calls by `this->FastEvaluateMovingImageValueAndDerivative(..., threadId)` in the "Threaded" member functions of six more metrics:
itkAdvancedKappaStatisticImageToImageMetric
itkAdvancedMeanSquaresImageToImageMetric
itkParzenWindowHistogramImageToImageMetric
itkParzenWindowMutualInformationImageToImageMetric
itkPCAMetric_F_multithreaded
itkSumSquaredTissueVolumeDifferenceImageToImageMetric
Expected a significant performance gain on the run-time duration.
`AdvancedKappaStatisticImageToImageMetric::ThreadedGetValueAndDerivative` is being tested by 55/161 - elastix_run_3DCT_lung.Kappa.bspline.ASGD.001_OUTPUT
`AdvancedMeanSquaresImageToImageMetric::ThreadedGetValueAndDerivative` is being tested by:
- 43/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.001_OUTPUT
- 98/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.002_OUTPUT
- 102/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.003_OUTPUT
- 106/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.001-Threads1_OUTPUT
- 110/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.001-Threads2_OUTPUT
- 114/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.001-Threads4_OUTPUT
`ParzenWindowHistogramImageToImageMetric::ThreadedComputePDFs` is being tested by:
- 20/161 - elastix_run_example_OUTPUT
- 47/161 - elastix_run_3DCT_lung.MI.bspline.ASGD.001_OUTPUT
- 82/161 - elastix_run_3DCT_lung.MI.bspline.SGD.001_OUTPUT
- 86/161 - elastix_run_3DCT_lung.MI.bspline.SGD.002_OUTPUT
- 90/161 - elastix_run_3DCT_lung.MI.bspline.SGD.003_OUTPUT
- 94/161 - elastix_run_3DCT_lung.MI.bspline.SGD.004_OUTPUT
- 130/161 - elastix_run_3DCT_lung.MI.bspline.SGD.001-Threads1_OUTPUT
- 134/161 - elastix_run_3DCT_lung.MI.bspline.SGD.001-Threads2_OUTPUT
- 138/161 - elastix_run_3DCT_lung.MI.bspline.SGD.001-Threads4_OUTPUT
Follow-up to pull request #556 commit c8c4a6a "PERF: Make AdvancedNormalizedCorrelationImageToImageMetric faster"
Added `Superclass::` to calls to the (protected) virtual member function `AdvancedImageToImageMetric::EvaluateMovingImageValueAndDerivative` (which has one (protected) override, from `MultiInputImageToImageMetricBase`). Doing so ensures that virtual dispatching is avoided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to pull request #556 "PERF: Make AdvancedNormalizedCorrelationImageToImageMetric faster"