ENH: Add GetParameterMaps and SetParameterMaps to ParameterObject #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equivalent to `GetParameterMaps()` and `SetParameterMap(const ParameterMapVectorType &)`. It appears more readable in these cases, to use the plural form "maps", rather than "map". Moreover, `SetParameterMaps` may be easier to use because it is not overloading.
N-Dekker
added a commit
that referenced
this pull request
May 23, 2023
Deprecated the old ReadParameterFile and WriteParameterFile overloads that support multiple files. Follow-up to: - pull request #848 commit 38b6152 "Add GetParameterMaps and SetParameterMaps to ParameterObject" - pull request #862 commit 0afcc3b "Deprecate Get/SetParameterMap in favor of Get/SetParameterMaps"
N-Dekker
added a commit
that referenced
this pull request
May 23, 2023
Deprecated the old ReadParameterFile and WriteParameterFile overloads that support multiple files. Follow-up to: - pull request #848 commit 38b6152 "Add GetParameterMaps and SetParameterMaps to ParameterObject" - pull request #862 commit 0afcc3b "Deprecate Get/SetParameterMap in favor of Get/SetParameterMaps"
N-Dekker
added a commit
that referenced
this pull request
May 23, 2023
Deprecated the old ReadParameterFile and WriteParameterFile overloads that support multiple files. Follow-up to: - pull request #848 commit 38b6152 "Add GetParameterMaps and SetParameterMaps to ParameterObject" - pull request #862 commit 0afcc3b "Deprecate Get/SetParameterMap in favor of Get/SetParameterMaps"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to
GetParameterMaps()andSetParameterMap(const ParameterMapVectorType &).It appears more readable in these cases, to use the plural form "maps", rather than "map". Moreover,
SetParameterMapsmay be easier to use because it is not overloading.