Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snail stomping #1337

Merged
merged 7 commits into from
Jul 17, 2020
Merged

Snail stomping #1337

merged 7 commits into from
Jul 17, 2020

Conversation

Zwatotem
Copy link
Member

@Zwatotem Zwatotem commented Feb 6, 2020

Snail now hides in the shell if he finds himself in danger of stomping. You can however still stomp him with buttjump action. Please test and review.

@busybody42

This comment has been minimized.

@Zwatotem
Copy link
Member Author

Zwatotem commented Feb 6, 2020

@busybody42 What are you talking about?

@busybody42
Copy link
Contributor

... Basically, this would probably trivialize the enemy's koopa shell-like gimmick...
It would go flying the instant it's jumped on the first time...
also, wouldn't this be unfair for smalltux players?

@tobbi
Copy link
Member

tobbi commented Feb 11, 2020

Is this ready to be merged?

@Zwatotem Zwatotem added help wanted priority:low status:in-progress Progress has been done, but more is intended be done labels Feb 12, 2020
@Zwatotem Zwatotem changed the title Snail stomping WIP Snail stomping Feb 12, 2020
@Zwatotem
Copy link
Member Author

I'm looking for someone to create graphic for this PR.

@tobbi
Copy link
Member

tobbi commented Feb 12, 2020

@Rusty-Box ^^ So you don't get bored!

@Alzter
Copy link
Member

Alzter commented Mar 4, 2020

Suggestions for snail stomping:

  • Normal Snail bounce makes Tux bounce off the Snail's shell, doesn't hurt player
  • Buttjump acts like normal stomp
  • Make kicking Snail shells not send them flying upwards as it makes has no clear benefit to the player and ends up being frustrating as it can miss enemies and hit you

@busybody42
Copy link
Contributor

Altzer, my reply to your suggestion is that kicking it does make it fly upwards, (but we do need to have a thing that explains that mechanic) but jumping on it doesn't make it go upwards, yet it still skids...

@Zwatotem
Copy link
Member Author

Zwatotem commented Mar 8, 2020

@Alzter: First two points are just, what's applied. Either third point or @busybody42's suggestion (or some variation of it) is considerable.

@Zwatotem
Copy link
Member Author

I'll bring the code to the end and merge with current sprites. They deserve separate PR.

Now kicking snails from the side doesn't set them flying upwards. Jumping on them and throwing works as prior.
@Zwatotem Zwatotem changed the title WIP Snail stomping Snail stomping Jul 16, 2020
@Zwatotem Zwatotem merged commit 60c723a into SuperTux:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low status:in-progress Progress has been done, but more is intended be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants