Crash fix: handle dragging a selection rectangle up/left correctly. #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft correctly. Previously, this created a Rectf instance with negative size, crashing the filled rectangle drawing routine. I previously considered rather making the drawing routine support this case, but then I started to wonder how to define the rounded rectangle radius in that case... and then I saw the pre-existing assert in the other Rectf constructor and decided that the intention was to not allow this in the first place. So, dragging code fixed instead.
Zwatotem
added
category:code
status:needs-review
mrkubax10
removed
the
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this created a Rectf instance with negative size, crashing
the filled rectangle drawing routine.
I previously considered rather making the drawing routine support this
case, but then I started to wonder how to define the rounded rectangle
radius in that case... and then I saw the pre-existing assert in the
other Rectf constructor and decided that the intention was to not allow
this in the first place. So, dragging code fixed instead.