Add Circular Pathed Platforms #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
Zwatotem
requested changes
Jul 17, 2020
|
I updated the pull request by updating with your suggestions and requirements @Zwatotem, but I don't understand your problems with the indentation seen as I cannot see the problems you are talking about. |
tux314159
pushed a commit
to tux314159/supertux
that referenced
this pull request
Jul 31, 2020
* Add circular platforms [ci skip] * update objects file [ci skip] * Add to gameobjectfactory * Add files via upload * Update objects.stoi [ci skip] * quality de la code [ci skip] * Update objects.stoi [ci skip] * Replaced tabs with spaces Co-authored-by: Zwatotem <zwatotem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds circular-pathed platforms to the game.
Yes, they do follow the same behavior as flames, moving around in a circle. You can set the radius and speed of their movement as well as a delay for when they begin moving. You can also change the sprite.
They could possibly be introduced in the ice bridge levels in Icy Island because 1) Those levels introduce no new mechanics and 2) They could "foreshadow" the introduction of the flames by introducing a docile/helpful variant and then showing you the enemy version of it.
This was quite simple of an object to add. Please test and review, and hopefully this will get merged once it looks all good.