Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worldmap scripting #1691

Closed
wants to merge 8 commits into from
Closed

Worldmap scripting #1691

wants to merge 8 commits into from

Conversation

Semphriss
Copy link
Member

This PR gives access to the settings object in worldmaps, thus permitting usage of ambient lighting and music from scripting.

@Semphriss Semphriss added the status:needs-review Work needs to be reviewed by other people label Mar 7, 2021
@Semphriss Semphriss mentioned this pull request Mar 7, 2021
src/scripting/worldmap.cpp Outdated Show resolved Hide resolved
src/scripting/worldmap.cpp Outdated Show resolved Hide resolved
src/scripting/worldmap.hpp Outdated Show resolved Hide resolved
src/worldmap/worldmap.cpp Show resolved Hide resolved
src/worldmap/worldmap.hpp Outdated Show resolved Hide resolved
@Semphriss Semphriss force-pushed the worldmap_scripting branch from 7bfe399 to a1a7585 Compare April 20, 2021 03:01
@Semphriss Semphriss requested a review from tobbi April 20, 2021 03:02
@tobbi
Copy link
Member

tobbi commented Apr 30, 2021

Please rebase.

@Semphriss
Copy link
Member Author

Superseded by #1692, which got properly rebased

@Semphriss Semphriss closed this May 17, 2021
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants