Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skull tiles now respawn 10 seconds after crumbling #1713

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

Semphriss
Copy link
Member

Fixes #1712

@serano01
Copy link
Member

That changes the skull tiles, but what about the unstable tiles? They are more used after all. And if I'm not mistaken, skull tiles are unaffected by explosions.

@Semphriss
Copy link
Member Author

Odd, I thought both were the same thing. Was there a reason to design both seperately at the moment of creation?

@serano01
Copy link
Member

Skull tiles only fall when the player has been on it for a sufficient time, unstable tiles on the other hand will always fall regardless on the time.

@Semphriss Semphriss added status:needs-review Work needs to be reviewed by other people status:needs-work In progress, but no one is currently working on it (New volunteers welcome) and removed status:needs-review Work needs to be reviewed by other people labels Mar 29, 2021
@Semphriss Semphriss added status:needs-review Work needs to be reviewed by other people and removed status:needs-work In progress, but no one is currently working on it (New volunteers welcome) labels Apr 4, 2021
@Semphriss
Copy link
Member Author

@serano01 Done; you may test changes to see if everything is good this way. Unstable tiles now respawn too, and both skulls and unstable tiles respawn after 5 seconds.

@tobbi tobbi merged commit 81924d2 into SuperTux:master Apr 6, 2021
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable tiles should be respawning
4 participants