Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix camera following tux when dying #2807

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix camera following tux when dying #2807

merged 1 commit into from
Mar 6, 2024

Conversation

Miner34dev
Copy link
Contributor

@Miner34dev Miner34dev commented Feb 26, 2024 •
edited by MatusGuy
Loading

fixes #2799

@MatusGuy MatusGuy changed the title Fix #2799 Fix camera following tux when dying Feb 26, 2024
tobbi
tobbi reviewed Feb 26, 2024
View reviewed changes
src/object/camera.cpp Outdated Show resolved Hide resolved
@mrkubax10 mrkubax10 added involves:functionality category:code status:needs-review Work needs to be reviewed by other people type:bugfix Pull Requests that fix bugs. labels Feb 27, 2024
@Vankata453
Copy link
Member

Perhaps this check should only be done right before update_scroll_normal()? This will allow for it to not include multiplayer (even so, it currently only checks for the first player anyway), as well as any other custom modes.

@Miner34dev
Copy link
Contributor Author

Anything else to change? I'm ready to squash the commits

Vankata453
Vankata453 reviewed Feb 27, 2024
View reviewed changes
src/object/camera.cpp Outdated Show resolved Hide resolved
@mrkubax10 mrkubax10 requested a review from tobbi February 28, 2024 16:02
@Rusty-Box Rusty-Box merged commit 6158e96 into SuperTux:master Mar 6, 2024
33 checks passed
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Mar 10, 2024
Vankata453 added a commit that referenced this pull request Mar 13, 2024
@Vankata453
Revert "Fix camera following tux when dying (#2807)"
2416688 
This reverts commit 6158e96.

Wehn dying with the camera zoomed in, translation would bug out, going far away out of sector bounds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobbi tobbi tobbi approved these changes

@mrkubax10 mrkubax10 mrkubax10 approved these changes

@Vankata453 Vankata453 Vankata453 approved these changes

Assignees
No one assigned
Labels
category:code involves:functionality type:bugfix Pull Requests that fix bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Camera keeps following Tux when dying
5 participants
@Miner34dev @Vankata453 @tobbi @mrkubax10 @Rusty-Box