Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to hide wind particles + set fancy as default #2997

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

bruhmoent
Copy link
Member

No description provided.

@MatusGuy MatusGuy changed the title Add an option to hide particles + set fancy as default Add an option to hide wind particles + set fancy as default Jul 4, 2024
@MatusGuy MatusGuy added category:code status:needs-review Work needs to be reviewed by other people labels Jul 4, 2024
Copy link
Member

@tobbi tobbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@MatusGuy MatusGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be more intuitive if you used an enum instead of two booleans. Up for discussion.

Other than that, seems to work fine.

@bruhmoent
Copy link
Member Author

I don't think that's necessary, I think it's already very clear.

@Vankata453 Vankata453 merged commit 31dc707 into SuperTux:master Jul 7, 2024
33 checks passed
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants