Make the Mole, Root Sapling, and Corrupted Big Granito a StickyBadguy #3135
+39
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2024 14:02
Bad logic anyway, will be improved later.
swagtoy
changed the title
|
Edit: No |
|
No? |
|
??? |
|
@swagtoy Btw. there were other instance of 'BadGuy' in 'corrupted_big_granito.cpp' in line 52 and 62. Wasn't sure if I also replace that with 'StickyBadguy' or not. |
|
Wait hold on this PR sucks a lot |
|
RE @Rusty-Box There is actually nothing wrong with calling Badguy::* functions, but for consistency I have made it go to the StickyBadguy in any situation where these functions may ever get overloaded |
swagtoy
changed the title
I wasn't calling the actual sticky related functions like an idiot. I have discussed that this can be refactored one day anyway, so it's whatever...
|
@Rusty-Box You can now test this again. I apparently didn't even call the sticky functions like an idiot. They are now getting called and I've also applied your suggestion. |
|
Just a note for myself: Need to fix Root Sapling and Corrupted Big Granito; these do not work in this PR. |
MatusGuy
approved these changes
Dec 16, 2024
Comment on lines
+49
to
+59
| const std::string& light_sprite_name = BADGUY_LIGHT_SPRITE_NAME, | ||
| const std::string& ice_sprite_name = BADGUY_ICE_SPRITE_NAME); | ||
| BadGuy(const Vector& pos, Direction direction, const std::string& sprite_name, int layer = LAYER_OBJECTS, | ||
| const std::string& light_sprite_name = "images/objects/lightmap_light/lightmap_light-medium.sprite", | ||
| const std::string& ice_sprite_name = "images/creatures/overlays/iceoverlay/iceoverlay.sprite"); | ||
| const std::string& light_sprite_name = BADGUY_LIGHT_SPRITE_NAME, | ||
| const std::string& ice_sprite_name = BADGUY_ICE_SPRITE_NAME); | ||
| BadGuy(const ReaderMapping& reader, const std::string& sprite_name, int layer = LAYER_OBJECTS, | ||
| const std::string& light_sprite_name = "images/objects/lightmap_light/lightmap_light-medium.sprite", | ||
| const std::string& ice_sprite_name = "images/creatures/overlays/iceoverlay/iceoverlay.sprite"); | ||
| const std::string& light_sprite_name = BADGUY_LIGHT_SPRITE_NAME, | ||
| const std::string& ice_sprite_name = BADGUY_ICE_SPRITE_NAME); | ||
| BadGuy(const ReaderMapping& reader, const std::string& sprite_name, Direction default_direction, int layer = LAYER_OBJECTS, | ||
| const std::string& light_sprite_name = "images/objects/lightmap_light/lightmap_light-medium.sprite", | ||
| const std::string& ice_sprite_name = "images/creatures/overlays/iceoverlay/iceoverlay.sprite"); | ||
| const std::string& light_sprite_name = BADGUY_LIGHT_SPRITE_NAME, | ||
| const std::string& ice_sprite_name = BADGUY_ICE_SPRITE_NAME); |
There was a problem hiding this comment.
One day we need to fix all this sprite parameter stuff because this looks pretty tedious hahaha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3132
I did some basic testing, but I need someone to properly test the stickiness.
Thank you!