Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move types condition to the front #343

Closed

Conversation

Andarist
Copy link

@Andarist Andarist commented May 1, 2023

I moved types condition to the front. package.json#exports are order-sensitive - they are always matched from the top to the bottom. When a match is found then it should be used and no further matching should occur.

Right now, the current setup works in TypeScript but it's considered a bug and it should not be relied upon, see the thread and the comment here. For that reason, I would like to fix all popular packages that misconfigured their exports this way so the bug can be fixed in TypeScript.

⚠️ this PR focuses solely on fixing "🐛 Used fallback condition" problem but the "🚭 Unexpected ESM syntax" remains here. You can check the reported errors here

@vercel
Copy link

vercel bot commented May 1, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @SupremeTechnopriest on Vercel.

@SupremeTechnopriest first needs to authorize it.

@SupremeTechnopriest
Copy link
Owner

Awesome! Thanks for the PR. I will get this merged up and published this weekend.

@Andarist
Copy link
Author

Andarist commented May 9, 2023

@SupremeTechnopriest friendly 🏓

1 similar comment
@Andarist
Copy link
Author

Andarist commented Jun 1, 2023

@SupremeTechnopriest friendly 🏓

@SupremeTechnopriest
Copy link
Owner

Hey @Andarist. This is resolved in the latest 5.7.2 release. I didn't merge this because it didn't follow the contribution guide, but I was doing some work on the exports anyway. I added a legacy bundle for older browsers as well. Thanks for reporting this! Let me know if you have any issues with the types. In the future just quickly gloss over the contribution guide and Ill be happy to merge your changes in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants