-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS styles assigned incorrectly when accessing subpage directly #11
Labels
Comments
nai888
added a commit
that referenced
this issue
May 10, 2018
Remove react-snap from the build process for now, since it is currently assigning CSS classes incorrectly (see issue #11). Updated CHANGELOG with recent changes.
nai888
added a commit
that referenced
this issue
May 10, 2018
Add toast notifications explanation to CHANGELOG. Add link to issue #11 about incorrect CSS class assignment.
As of v0.1.4, react-snap has been removed from the project until this can be solved. React-snap isn't critical to the project, so getting this solved is currently low priority. |
Merged
Fixed by #567 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Langua Version
0.1.3
Expected Behavior
Load each page's styles accurately, even if accessing a subpage directly.
Actual Behavior
When loading a subpage directly, the CSSinJS classes are assigned incorrectly, which causes elements to have the wrong appearance.
Steps to Reproduce
Load a subpage directly (e.g. go straight to https://nai888.github.io/langua/gen without loading the homepage first).
Note: since react-snap doesn't come into play until the build process, the issue only happens on the built static site, not on the development server.
Observations
This is an issue with react-snap generating a static HTML file with predefined CSS classes and then CSSinJS dynamically assigning the CSS classes to elements on the page. This is why loading the home page first works, because the elements are rendered in the "correct order" for the classes to be dynamically assigned to elements in the correct order.
The text was updated successfully, but these errors were encountered: