-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
className={props.styles.categoryVariable} | ||
value={cat.variable} | ||
readOnly | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label
attribute.
className={props.styles.categoryLetters} | ||
value={cat.letters.join('/')} | ||
readOnly | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label
attribute.
className={props.styles.rewriteRulePattern} | ||
value={rule.pattern} | ||
readOnly | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label
attribute.
className={props.styles.rewriteRuleSubstitution} | ||
value={rule.substitution} | ||
readOnly | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label
attribute.
className={props.styles.soundChange} | ||
value={compileSoundChange(change)} | ||
readOnly | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label
attribute.
className={props.styles.lexicon} | ||
value={lexicon(props.data.lexicon)} | ||
readOnly | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label
attribute.
Your pull request is passing all TravisCI testsHey @nai888, Thanks for your contribution! It looks like your pull request is passing all the TravisCI tests, so we’ll review everything as soon as we can. TravisBuddy Request Identifier: 8e51aca0-04c0-11e9-a944-9d9302626d36 |
Changes proposed in this pull request
@nai888