Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #140

Merged
merged 4 commits into from
Dec 21, 2018
Merged

Dev #140

merged 4 commits into from
Dec 21, 2018

Conversation

nai888
Copy link
Collaborator

@nai888 nai888 commented Dec 21, 2018

Changes proposed in this pull request

  • Add tool tests.
  • Add data to MorphForm page.

@nai888

@nai888 nai888 added enhancement enhancement to the site's features or functionality code improvement improvement to the quality or cleanliness of the code labels Dec 21, 2018
@nai888 nai888 self-assigned this Dec 21, 2018
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

className={props.styles.categoryVariable}
value={cat.variable}
readOnly
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

className={props.styles.categoryLetters}
value={cat.letters.join('/')}
readOnly
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

className={props.styles.rewriteRulePattern}
value={rule.pattern}
readOnly
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

className={props.styles.rewriteRuleSubstitution}
value={rule.substitution}
readOnly
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

className={props.styles.soundChange}
value={compileSoundChange(change)}
readOnly
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

className={props.styles.lexicon}
value={lexicon(props.data.lexicon)}
readOnly
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

@TravisBuddy
Copy link

Your pull request is passing all TravisCI tests

Hey @nai888,

Thanks for your contribution! It looks like your pull request is passing all the TravisCI tests, so we’ll review everything as soon as we can.

View build log

TravisBuddy Request Identifier: 8e51aca0-04c0-11e9-a944-9d9302626d36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvement improvement to the quality or cleanliness of the code enhancement enhancement to the site's features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants