Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke file picker when Open button is clicked #55

Merged
merged 2 commits into from
Oct 6, 2018
Merged

Invoke file picker when Open button is clicked #55

merged 2 commits into from
Oct 6, 2018

Conversation

Spring3
Copy link
Contributor

@Spring3 Spring3 commented Oct 1, 2018

Issues related to this pull request

Changes proposed in this pull request

  • Setting ref to the file picker and programmatically invoking click event

@nai888

oct-02-2018 02-54-35

@nai888 nai888 added the enhancement enhancement to the site's features or functionality label Oct 2, 2018
@nai888 nai888 self-requested a review October 2, 2018 00:55
@nai888
Copy link
Collaborator

nai888 commented Oct 2, 2018

@Spring3 Fabulous, thank you so much! I'll have time to review this more closely later this week.

Copy link
Collaborator

@nai888 nai888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

Since I'm using yarn instead of npm, I'm going to delete package-lock.json. I'll also make a few other small adjustments (e.g. with this change, I no longer need to dynamically assign and remove a class to hide and show the file input). Otherwise, it's working great!

You've also now taught me about refs, which I didn't know about. 😄

@nai888 nai888 merged commit 0ad9ce1 into Susurrus-LLC:master Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement to the site's features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants