Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for MultiSelectListPreference #258

Merged
merged 4 commits into from
Nov 28, 2021
Merged

add support for MultiSelectListPreference #258

merged 4 commits into from
Nov 28, 2021

Conversation

AriaMoradi
Copy link
Member

No description provided.

@AriaMoradi AriaMoradi requested review from Syer10 and ntbm November 28, 2021 19:09
@AriaMoradi
Copy link
Member Author

AriaMoradi commented Nov 28, 2021 •
edited
Loading

@Syer10 Your implementation of StringSet for JavaSharedPreferences didn't work, so I rewrote it using Json, if a better/fixed implementation is existed then that would be desirable.

@AriaMoradi @Syer10
Update AndroidCompat/src/main/java/xyz/nulldev/androidcompat/io/share…
1dece94 
…dprefs/JavaSharedPreferences.kt

Co-authored-by: Mitchell Syer <Mitchellptbo@gmail.com>
@Syer10
Copy link
Collaborator

Syer10 commented Nov 28, 2021

@Syer10 Your implementation of StringSet for JavaSharedPreferences didn't work, so I rewrote it using Json, if a better/fixed implementation is existed then that would be desirable.

Thats really weird, thats the standard way for handling sets/list with Multiplatform Preferences

@AriaMoradi AriaMoradi mentioned this pull request Nov 28, 2021
Merged
@AriaMoradi AriaMoradi merged commit 2478aa7 into master Nov 28, 2021
@AriaMoradi AriaMoradi deleted the MultiSelectListPreference branch November 28, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syer10 Syer10 Syer10 approved these changes

@ntbm ntbm Awaiting requested review from ntbm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AriaMoradi @Syer10