Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Double pager: Go back on single spread page when previous page was displayed as single page will cause the previous page to be displayed as double page #181

Closed
tts2k opened this issue Aug 11, 2022 · 0 comments · Fixed by #203
Labels
bug Something isn't working

Comments

@tts2k
Copy link

tts2k commented Aug 11, 2022

Device information

  • Tachidesk version: (v0.6.3)
  • Server Operating System: (Arch Linux)
  • Server Desktop Environment: bspwm
  • Server JVM version: OpenJDK 18
  • Client Operating System: Arch Linux
  • Client Web Browser: Firefox 102.0.1

Steps to reproduce

  1. Enable Double page mode
  2. Open a chapter that has a single spread page with a previous page displayed as single page (like this)
  3. Open a spread page (page 4 with the example above).
  4. Go back to previous page (page 3)

Expected behavior

Page 3 should be displayed as single page.

Actual behavior

Page 3 was displayed as double page with page 2 instead

Other details

I think this could be a quick fix by keeping track if previous page was a single page when a single spread page is displayed. I can try to fix it with a PR. Nevermind, it's more complicated than I thought. I'll try to play around with it a little bit

@tts2k tts2k added the bug Something isn't working label Aug 11, 2022
martinek added a commit to martinek/Tachidesk-WebUI that referenced this issue Nov 26, 2022
AriaMoradi pushed a commit that referenced this issue Nov 26, 2022
#203)

* Update logic for determining if page should be single or double in double layout to cover issue #181

* Simplify code, add special handling for last page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant