Fix issue 52 – prevent vertical collapsing of text on iOS 14 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md # fastlane/Fastfile
AndrewBennet
changed the title
AndrewBennet
changed the title
|
Great find 👍 |
Closed
|
Your changes are now available with the new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
Applying a fix which I have used in my own apps before – adding
fixedSize(horizontal: false, vertical: true)– prevents the text truncation from happening. Looks like it has actually been fixed in iOS 15 anyway, so you could consider having a modifier which only applies this modifier when iOS 15 is not available, but not sure if that's necessary.See before change:
After: