Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extension signatures #55

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Fix extension signatures #55

merged 2 commits into from
Apr 26, 2022

Conversation

phjs
Copy link
Contributor

@phjs phjs commented Apr 26, 2022

  • I fixed a typo in a method signature. To ensure backward compatibility, I kept the old one but marked it as deprecated
  • Fixed some other typos

@phjs
Fix typo in method signature
275ec4c 
Mark old method as depricated
@phjs
Fix typos
2a9322a
@SvenTiigi SvenTiigi changed the base branch from master to develop April 26, 2022 15:11
@SvenTiigi SvenTiigi added the enhancement New feature or request label Apr 26, 2022
@SvenTiigi
Copy link
Owner

Hey @phjs,

Great find I have definitely missed out that typo 😅
Love the idea of adding a deprecation warning to the old function signature.

I will let you know when the changes are available with a new Version of WhatsNewKit ✌️

@SvenTiigi SvenTiigi merged commit 7dcdbc2 into SvenTiigi:develop Apr 26, 2022
@phjs phjs deleted the Fix-extension-signatures branch April 26, 2022 15:31
@phjs
Copy link
Contributor Author

phjs commented Apr 26, 2022

I didn't even notice it during development. Only later in the review.
Thank you for developing this helpful package.

@SvenTiigi
Copy link
Owner

The changes are now available with the new version 2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phjs @SvenTiigi