11 Networking.Persistence Module with DAO abstract class, implementations and builder #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
Closed
4 tasks
|
Found a tutorial on how to add firebase. So I can probably set it up later today |
mvbryne
reviewed
Mar 13, 2024
core/src/com/softwarearchitecture/networking/persistence/DAO.java
Outdated
Show resolved
Hide resolved
mvbryne
reviewed
Mar 13, 2024
core/src/com/softwarearchitecture/networking/persistence/LocalDAO.java
Outdated
Show resolved
Hide resolved
…dency" This reverts commit 983bd42.
There was a problem hiding this comment.
Rename this to LocalDAO or StorageDAO? More descriptive than MockDAO, especially if it's going to be used for tests.
There was a problem hiding this comment.
Or i don't see the reason to test something that won't be used, if that makes sense
| @Before | ||
| public void setUp() { | ||
| // dao with all capabilities | ||
| mockDAO = new MockDAO<>(true, true, true, true); |
There was a problem hiding this comment.
Is this standard, why can't we enforce/expect all the CRUD-operations to be implemented?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network.persistence module
This PR adds the following to the project:
There are also tests for this functionality
To run all the tests: