Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

togl: use PBO instead glGetTexImage #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nillerusr
Copy link

No description provided.

@nillerusr
Copy link
Author

That should help with dlights

@LWSS
Copy link
Contributor

LWSS commented Oct 1, 2022

2022-10-01-104933_4480x1440_scrot

oy I think I broke it, the dlights still work tho. Did u make any more changes elsewhere? I didn't get the header file in the commit

@LWSS
Copy link
Contributor

LWSS commented Oct 1, 2022

yeah if I put kGLMTexDynamic onto more types, it seems to work but it breaks the net_graph text

@nillerusr
Copy link
Author

Well i forget header file yes

@LWSS
Copy link
Contributor

LWSS commented Oct 1, 2022

yeah i figured those out but I get black textures after dlights occur unless I put dynamic on every texture(and then the vgui fonts break)

@nillerusr
Copy link
Author

yeah i figured those out but I get black textures after dlights occur unless I put dynamic on every texture(and then the vgui fonts break)

Lol what

@nillerusr
Copy link
Author

Don't do that

@LWSS
Copy link
Contributor

LWSS commented Oct 1, 2022

yeah i wasn't gonna, just testing something

@nillerusr
Copy link
Author

nillerusr commented Oct 1, 2022

Hmm maybe that's only csgo problem. I don't have problems like that in css/hl2

@nillerusr
Copy link
Author

Well, in csgo lightmaps are updated in the same way as in css. Maybe the implementation of togl is changed somewhere

@nillerusr
Copy link
Author

image
LoL

@LWSS
Copy link
Contributor

LWSS commented Oct 1, 2022

weed-vision

@nillerusr
Copy link
Author

Well, I needed to rebuild everything to which togl links.
image

@LWSS
Copy link
Contributor

LWSS commented Oct 1, 2022

yo for some reason in csgo there's like 2-3 different versions of this glm code.

The enums don't even match 💀

https://github.com/SwagSoftware/Kisak-Strike/blob/master/public/togl/cglmtex.h#L96

https://github.com/SwagSoftware/Kisak-Strike/blob/master/public/glmgr/cglmtex.h#L79

yeah they're unused though, didn't fix anything

@nillerusr
Copy link
Author

Hmm try to run with -gl_debug

@nillerusr
Copy link
Author

Oops maybe that's my fault. I found funny bug
image

@nillerusr
Copy link
Author

nillerusr commented Oct 1, 2022

For textures locked with D3DLOCK_READONLY flag must be used old reading method, well

@LWSS
Copy link
Contributor

LWSS commented Oct 1, 2022

didn't seem to be the issue for me. I'll mess with it later

@LWSS
Copy link
Contributor

LWSS commented Oct 1, 2022

Testing FPS drop (by setting all textures to dynamic to get this to work), it seems to work really good, there's basically no drop with my 4 dlight test at 300fps cap.

@LWSS
Copy link
Contributor

LWSS commented Oct 1, 2022

2022-10-01-162750_4480x1440_scrot

bro why are there some walls that are just immune to dlights? (Even with regular code). I swear this game is so jank. Probably some random wall texture flag?

The main problem with CS:GO is that the asset-pipeline sucks major nuts. Redo'ing that is also a lot of work, but hammer should just be dumpster'd and we make a trenchbroom mod or something

@nillerusr
Copy link
Author

nillerusr commented Oct 2, 2022

I have an idea. Try to build this for csgo https://github.com/nillerusr/source-engine/tree/master/togles
It uses OpenGLES 3.2( and can work opengl 3.2 core context )

@blackletum
Copy link

I have an idea. Try to build this for csgo https://github.com/nillerusr/source-engine/tree/master/togles It uses OpenGLES 3.2( and can work opengl 3.2 core context )

was this ever attempted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants