Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New user dashboard #1335

Merged
merged 26 commits into from
Sep 5, 2022
Merged

New user dashboard #1335

merged 26 commits into from
Sep 5, 2022

Conversation

wixzi
Copy link
Contributor

@wixzi wixzi commented Aug 5, 2022 •
edited
Loading

Summary

Fixes #1288
Screenshot 2022-08-26 at 16 53 38
Screenshot 2022-08-26 at 16 53 50

To Test

Go to user dashboard from the ENS name or your wallet address. You should be able to see your recent transactions

Background

@wixzi wixzi added the WIP label Aug 5, 2022
@netlify
Copy link

netlify bot commented Aug 5, 2022 •
edited
Loading

✅ Deploy Preview for swapr ready!

Name Link
🔨 Latest commit 398d430
🔍 Latest deploy log https://app.netlify.com/sites/swapr/deploys/6315f2f89b67110008c66715
😎 Deploy Preview https://deploy-preview-1335--swapr.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot temporarily deployed to feature-new-user-profile August 18, 2022 08:05 Destroyed
@github-actions github-actions bot temporarily deployed to feature-new-user-profile August 19, 2022 07:57 Destroyed
@github-actions github-actions bot temporarily deployed to feature-new-user-profile August 19, 2022 08:06 Destroyed
@github-actions github-actions bot temporarily deployed to feature-new-user-profile August 19, 2022 17:09 Destroyed
@github-actions github-actions bot temporarily deployed to feature-new-user-profile August 19, 2022 21:36 Destroyed
@github-actions github-actions bot temporarily deployed to feature-new-user-profile August 21, 2022 21:27 Destroyed
@github-actions github-actions bot temporarily deployed to feature-new-user-profile August 22, 2022 13:17 Destroyed
@MilanVojnovic95
Copy link
Collaborator

Tested and looks ok to me on Desktop 👍
It will be tested on Mobile later.

@github-actions github-actions bot temporarily deployed to feature-new-user-profile August 25, 2022 21:57 Destroyed
@github-actions github-actions bot temporarily deployed to feature-new-user-profile August 26, 2022 08:09 Destroyed
@wixzi wixzi marked this pull request as ready for review August 26, 2022 14:48
@github-actions github-actions bot temporarily deployed to feature-new-user-profile August 26, 2022 14:48 Destroyed
@wixzi wixzi requested review from adamazad and berteotti and removed request for adamazad August 26, 2022 14:48
@wixzi wixzi removed the WIP label Aug 26, 2022
@wixzi wixzi changed the title Feature/new user profile New user dashboard Aug 26, 2022
@wixzi wixzi requested a review from adamazad August 26, 2022 15:00
@github-actions github-actions bot temporarily deployed to feature-new-user-profile August 26, 2022 15:10 Destroyed
@MilanVojnovic95
Copy link
Collaborator

Tested on mobile and looks ok to me 👍

@niemam29
Copy link
Contributor

niemam29 commented Aug 29, 2022 •
edited
Loading

Hey! I've noticed that there should be 1/1 i think
cach2
Also when i have connected both Metamask and WalletConnect wallet the history of transations do not update correctly - here you can see that there is a tx from other wallet than chosen

s.mp4

berteotti
berteotti reviewed Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@berteotti berteotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looking good! Left some comments.

src/pages/Account/Account.styles.tsx Outdated Show resolved Hide resolved
src/pages/Account/Account.styles.tsx Outdated Show resolved Hide resolved
src/pages/Account/TokenIcon.tsx Outdated Show resolved Hide resolved
src/pages/Account/TokenIcon.tsx Outdated Show resolved Hide resolved
src/pages/Account/TransactionRows/BridgeTransactionRow.tsx Show resolved Hide resolved
src/pages/Account/TransactionRows/BridgeTransactionRow.tsx Show resolved Hide resolved
src/services/EcoBridge/OmniBridge/OmniBridge.utils.ts Outdated Show resolved Hide resolved
src/state/bridgeTransactions/types.ts Outdated Show resolved Hide resolved
src/state/lists/hooks.ts Outdated Show resolved Hide resolved
.env.development.local Show resolved Hide resolved
mix1o
mix1o reviewed Aug 29, 2022
View reviewed changes
src/components/Logo/index.tsx Outdated Show resolved Hide resolved
src/components/Web3Status/index.tsx Outdated Show resolved Hide resolved
src/pages/Account/Account.tsx Outdated Show resolved Hide resolved
src/pages/Account/Account.tsx Outdated Show resolved Hide resolved
src/pages/Account/Account.tsx Outdated Show resolved Hide resolved
src/pages/Account/TransactionRows/SwapTransactionRow.tsx Outdated Show resolved Hide resolved
src/pages/Account/TransactionRows/SwapTransactionRow.tsx Outdated Show resolved Hide resolved
src/pages/Account/TransactionRows/SwapTransactionRow.tsx Outdated Show resolved Hide resolved
src/pages/Account/TransactionRows/SwapTransactionRow.tsx Outdated Show resolved Hide resolved
src/pages/Pools/Pair/index.tsx Outdated Show resolved Hide resolved
@wixzi
Copy link
Contributor Author

wixzi commented Aug 29, 2022

@niemam29 Can you do one more round of testing?

Wixzi added 25 commits September 5, 2022 14:58
Account with transaction details
3001f9d
Added token logo and grouped logic
4838259
UserAccount Page with swap
7c509f3
Cleanup old Account Details
f32e3c3
Style and ENS avatar fixes
d6c2638
Fix network icon not showing issue
8dd6ec4
Remove fallback image
b9d79d1
Remove hexagonal clipping
455dffa
Add bridge transactions to user dashboard
1ff12a4
Fix design issues and add pending filter
e93faac
Remove ensName as default export
1b1cf2b
Update bridge transactions with to value
80ee9af
Refactor and cleanup code
8498a5d
Row Component refactor
cecd92c
Fix Mobie view
dd1e298
Sorting pending transactions to the top
60941d0
Update Transaction Headers
90a6d38
Fix PR comments
a6a2925
Update UI and add comments
4f11e71
Update omni brige toValue
19ad134
Move StyledElements to seperate folder in UI
6f6a823
Fix socket tovalue formatting
672528f
Use structuredClone instead of cloneDeep from lodash
d21da63
Fix sorting
982d44b
Fix PR comments
398d430
@wixzi wixzi dismissed Mi-Lan’s stale review September 5, 2022 13:02

Requested changes are addressed or commented with reasoning

@wixzi wixzi merged commit ed7e4b5 into develop Sep 5, 2022
@adamazad adamazad deleted the feature/new-user-profile branch November 29, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berteotti berteotti berteotti approved these changes

@MilanVojnovic95 MilanVojnovic95 MilanVojnovic95 approved these changes

@adamazad adamazad Awaiting requested review from adamazad

@Mi-Lan Mi-Lan Awaiting requested review from Mi-Lan

@mix1o mix1o Awaiting requested review from mix1o

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User dashboard
6 participants
@wixzi @MilanVojnovic95 @niemam29 @berteotti @Mi-Lan @mix1o