Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SWA-141][FEAT] - Change default Gnosis Chain output token to $WETH #1899

Merged
merged 2 commits into from
Jan 18, 2024
Merged

[SWA-141][FEAT] - Change default Gnosis Chain output token to $WETH #1899

merged 2 commits into from
Jan 18, 2024

Conversation

ElRodrigote
Copy link
Collaborator

Fixes: SWA-141

Description

  • Update the pre-selected output currency for Gnosis, to be WETH

Visual Evidence

image

How to test the changes

  1. Pull this branch
  2. Run the project locally
  3. Go to Swapr dapp page
  4. Connect your wallet
  5. For Gnosis Chain, you should see pre-selected $XDAI (native token) as the input token and $WETH as the output token in the Swapbox

@netlify Netlify
Copy link

netlify bot commented Jan 18, 2024 •
edited
Loading

✅ Deploy Preview for swapr ready!

Name Link
🔨 Latest commit 3cccafd
🔍 Latest deploy log https://app.netlify.com/sites/swapr/deploys/65a953610b16370008f94996
😎 Deploy Preview https://deploy-preview-1899--swapr.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 25 (no change from production)
Accessibility: 80 (no change from production)
Best Practices: 92 (no change from production)
SEO: 67 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot had a problem deploying to feat-swa-141-change-default-tokens-to-xdai-weth-on-gnosis-chain January 18, 2024 16:41 Failure
berteotti
berteotti approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@berteotti berteotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ElRodrigote ElRodrigote merged commit d9a3c99 into develop Jan 18, 2024
17 of 18 checks passed
ElRodrigote added a commit that referenced this pull request Feb 2, 2024
@ElRodrigote
[SWA-141][FEAT] - Change default Gnosis Chain output token to $WETH (#…
f1b67e7 
…1899)

* feat(SWA-141): update the pre-selected output currency for Gnosis, to be WETH
ElRodrigote added a commit that referenced this pull request Feb 2, 2024
@ElRodrigote
[SWA-141][FEAT] - Change default Gnosis Chain output token to $WETH (#…
723f213 
…1899)

* feat(SWA-141): update the pre-selected output currency for Gnosis, to be WETH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berteotti berteotti berteotti approved these changes

@Diogomartf Diogomartf Awaiting requested review from Diogomartf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElRodrigote @berteotti