Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STK-153][POC] - Add Shutter RPC button #1926

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Conversation

ElRodrigote
Copy link
Collaborator

Fixes: STK-153

Description

  • Adds the initial logic to connect through Metamask

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for swapr ready!

Name Link
🔨 Latest commit 8d42dec
🔍 Latest deploy log https://app.netlify.com/sites/swapr/deploys/66ffb586aec2e2000804cfc1
😎 Deploy Preview https://deploy-preview-1926--swapr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25
Accessibility: 79
Best Practices: 92
SEO: 83
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Diogomartf
Copy link
Collaborator

Design feedback
sometimes it breaks (probably we need some css to fix breaking)

image

@Diogomartf
Copy link
Collaborator

Diogomartf commented Sep 25, 2024

there are a couple of issues with this PR:

  • this should only appear if the user is on gnosis chain (because it only works there so no point on showing on other networks)
  • after adding the networks it keeps showing the button (if I'm on shutterized gnosis network already I don't need to see the button), let's show "protected by (icon + shutter logo)".
  • if the user already has added the network to the connected wallet, if he changes to gnosis network, we can show "proctect with (icon + shutter logo)" and by clicking it toggles change networks to gnosis shutter.
  • we should add the "?" icon and tootip on hover with info about shutter like we have on settings (eg. multihop).

I think we need to solve this issues in order to ship this.

@Diogomartf
Copy link
Collaborator

Diogomartf commented Sep 25, 2024

they updated their logo, so we should update it, it's a shield now. (maybe ask them the svg)

their new logo
image

Probably use their blue color as bg on the button? Might look better.

Design sketch:

  • adding the icon and logo together
  • add ? icon with tooltip and small explanation as we have in settings
  • shutter blue bg (we can try with our current gradient one first, and the see how it feels with the blue)
image

@ElRodrigote ElRodrigote marked this pull request as ready for review October 3, 2024 09:42
@ElRodrigote ElRodrigote merged commit 3847573 into develop Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants