Improve PDF conversion performance #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks really great. I will just try out few sample cases from my side too. Also, Can you please add the name of this dependency to this list https://github.com/Swati4star/Images-to-PDF#dependencies ..and stash the two commits :) |
|
Hm...am I missing something? I only see one commit in the pull request. I also see an update to the dependency list in the README. I could be looking at the wrong thing though. |
|
Sorry. My bad. I didn't see the change in Readme.md file. I will merge it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to address the following issue: #53.
This change seeks to improve the PDF conversion performance by using a different image compression library. I performed timing logging for the creation of the PDF and found the following results using the same file.
1 Image (3.74 MB):