Image-to-pdf: Filename InputField is autofilled with the filename #796
Conversation
…lowed by _pdf suffix
|
Code Climate has analyzed commit 4d7e81b and detected 0 issues on this pull request. View more on Code Climate. |
| /** | ||
| * Returns the last file name obtained from filepath | ||
| */ | ||
| private String getLastFileName(ArrayList<String> filesPath) { |
There was a problem hiding this comment.
there are already a lot of functions in this file.
Can we move this and next function to FileUtils?
There was a problem hiding this comment.
yes, moved to FileUtils.
| return nameWithoutExt + getString(swati4star.createpdf.R.string.pdf_suffix); | ||
| } | ||
|
|
||
| private String stripExtension(String str) { |
There was a problem hiding this comment.
please add javadoc style comments to newly added functions
There was a problem hiding this comment.
yup added javadoc.
| @@ -194,7 +195,8 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, | |||
| } | |||
|
|
|||
| @OnClick(R.id.tvNoOfImages) | |||
| public void onClick() { } | |||
| public void onClick() { | |||
There was a problem hiding this comment.
oops, sorry. before committing I had done "reformat code" which had added space between parentheses and moved the brace to the new line. I have reverted the code style the way it was before.
|
great @sudeshim3 👍 |
|
Merging this PR |
|
yup will work on it. |
FileName input field is auto-filled followed by _pdf suffix.
Say, if the file name is android.jpg the autofill text is android_pdf
Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
If there are any UI change, please include the screenshots also.
Fixes #(issue)
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist: