Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of rust-cache triggers warnings about usage of Node.js 16 #189

Closed
carsten-wenderdel opened this issue Feb 26, 2024 · 0 comments
Closed

Usage of rust-cache triggers warnings about usage of Node.js 16 #189

carsten-wenderdel opened this issue Feb 26, 2024 · 0 comments

Comments

@carsten-wenderdel
Copy link
Contributor

Currently every usage of this plugin triggers a warning, see for example https://github.com/Swatinem/rust-cache/actions/runs/7772794956/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Cause is the usage of version 3 of actions/checkout.

As rust-cache already migrated from Node 16 to Node 20 itself, I think it makes sense to upgrade to version 4 of actions/checkout.

I'm going to create a PR for that.
carsten-wenderdel added a commit to carsten-wenderdel/rust-cache that referenced this issue Feb 26, 2024
@carsten-wenderdel
Upgrade checkout action from version 3 to 4
ee2a7cc 
This fixes issue Swatinem#189.

This is necessary because GitHub actions are going to drop support for Node.js 16.
Version 4 uses Node.js 20.
See https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
@carsten-wenderdel carsten-wenderdel mentioned this issue Feb 26, 2024
Merged
Swatinem pushed a commit that referenced this issue Feb 27, 2024
@carsten-wenderdel
Upgrade checkout action from version 3 to 4 (#190)
640a221 
This fixes issue #189.

This is necessary because GitHub actions are going to drop support for Node.js 16.
Version 4 uses Node.js 20.
See https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carsten-wenderdel @Swatinem