fix: cache key dependency on installed packages #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the installed packages to the environment element of the cache key so that CI tooling is considered. This ensures that rust CI tooling is cached correctly when changes occur. Prior to this a manual key change or cache expiry would need to occur before CI tools were correctly cached.
Swatinem
approved these changes
May 11, 2023
|
Thanks for merging all the PR's @Swatinem. Would you like one to update change log so you can do a release? |
|
That would be nice indeed! And thank you so much for the great work, I appreciate that a lot :-) |
stevenh
added a commit
to stevenh/rust-cache
that referenced
this pull request
May 16, 2023
Ensure consistency of main and post configuration by storing and restoring it from state. Also: * Fixed some typos. * Use core.error for logging errors. Reverts: Swatinem#138 Fixes Swatinem#140
stevenh
added a commit
to stevenh/rust-cache
that referenced
this pull request
May 16, 2023
Ensure consistency of main and post configuration by storing and restoring it from state, which in turn ensures cache key stability. Also: * Fixed some typos. * Use core.error for logging errors. Reverts: Swatinem#138 Fixes Swatinem#140
stevenh
added a commit
to stevenh/rust-cache
that referenced
this pull request
May 16, 2023
Ensure consistency of main and post configuration by storing and restoring it from state, which in turn ensures cache key stability. Also: * Fixed some typos. * Use core.error for logging errors. Reverts: Swatinem#138 Fixes Swatinem#140
stevenh
added a commit
to stevenh/rust-cache
that referenced
this pull request
May 16, 2023
Ensure consistency of main and post configuration by storing and restoring it from state, which in turn ensures cache key stability. Also: * Fixed some typos. * Use core.error for logging errors. Reverts: Swatinem#138 Fixes Swatinem#140
stevenh
added a commit
to stevenh/rust-cache
that referenced
this pull request
May 16, 2023
Ensure consistency of main and post configuration by storing and restoring it from state, which in turn ensures cache key stability. Also: * Fixed some typos. * Use core.error for logging errors. Reverts: Swatinem#138 Fixes Swatinem#140
stevenh
added a commit
to stevenh/rust-cache
that referenced
this pull request
May 16, 2023
Ensure consistency of main and post configuration by storing and restoring it from state, which in turn ensures cache key stability. Also: * Fixed some typos. * Use core.error for logging errors. Reverts: Swatinem#138 Fixes Swatinem#140
stevenh
added a commit
to stevenh/rust-cache
that referenced
this pull request
May 17, 2023
Ensure consistency of main and post configuration by storing and restoring it from state, which in turn ensures cache key stability. Also: * Fixed some typos. * Use core.error for logging errors. Reverts: Swatinem#138 Fixes Swatinem#140
stevenh
added a commit
to stevenh/rust-cache
that referenced
this pull request
May 17, 2023
Ensure consistency of main and post configuration by storing and restoring it from state, which in turn ensures cache key stability. Also: * Fixed some typos. * Use core.error for logging errors. * Fix inverted condition on cache-all-crates. Reverts: Swatinem#138 Fixes Swatinem#140
stevenh
added a commit
to stevenh/rust-cache
that referenced
this pull request
May 17, 2023
Ensure consistency of main and post configuration by storing and restoring it from state, which in turn ensures cache key stability. Also: * Fixed some typos. * Use core.error for logging errors. * Fix inverted condition on cache-all-crates. Reverts: Swatinem#138 Fixes Swatinem#140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the installed packages to the environment element of the cache key so that CI tooling is considered.
This ensures that rust CI tooling is cached correctly when changes occur. Prior to this a manual key change or cache expiry would need to occur before CI tools were correctly cached.
Fixes #134