Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESY-6972 Decorate use case card with supported payment method(s) #2334

Merged

Conversation

m-lilja
Copy link
Contributor

@m-lilja m-lilja commented Sep 6, 2024

ESY-6972 Decorate use case card with supported payment method(s)
https://payexjira.atlassian.net/browse/ESY-6972

Also fixed error in code example

@m-lilja m-lilja requested a review from arebra September 6, 2024 13:24
@m-lilja m-lilja requested a review from a team as a code owner September 6, 2024 13:24
@probot-autolabeler probot-autolabeler bot added the documentation Improvements or additions to documentation label Sep 6, 2024
Copy link
Member

@arebra arebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@@ -116,7 +116,7 @@ api-supported-versions: 3.x/2.0{% endcapture %}
"expiryDate": "12/2033"
}
// ... other details
}
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected typo causing error in code example

<span><p>Save your customer's details and make their checkout faster.</p>
<span>
<p>Save your customer's details and make their checkout faster.</p>
<span class="badge badge-gray-light">Card</span>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code <span class="badge badge-gray-light">Payment method name</span> result in a grey badge on the card, shown in the screenshot below

image

@@ -126,8 +136,6 @@ below to read more." %}
[swp-logo]: /assets/img/swedbank-pay-vertical-black.svg
[swish-logo]: /assets/img/icon-swish-simple.svg
[trustly-logo]: /assets/img/icon-trustly-simple.svg
[wcag-presentation]: https://www.swedbankpay.com/information/wcag
[paid]: /checkout-v3/features/technical-reference/resource-sub-models#paid
Copy link
Contributor Author

@m-lilja m-lilja Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autoremoved (i.e. not by me), seems these links are not in use and were therefore removed automatically. You can hopefully verify if this is true or not.

@arebra arebra merged commit 3f39256 into develop Sep 9, 2024
26 of 28 checks passed
@arebra arebra deleted the feature/ESY-6972_Payment_method_badge_for_use_cases branch September 9, 2024 08:07
Copy link
Contributor

mergify bot commented Sep 9, 2024

Thank you @m-lilja for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants