implement Expecto Support #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
neoeinstein
reviewed
Dec 12, 2016
| @@ -82,13 +83,19 @@ module Internal = | |||
| //issue in vs 2010: http://stackoverflow.com/questions/2024036/strange-fsi-exe-behavior | |||
| if assemblies |> Seq.exists (fun a -> a.GetName().Name = "Fuchu") then | |||
| yield Fuchu (Type.GetType("Fuchu.AssertException, Fuchu")) | |||
| elif assemblies |> Seq.exists (fun a -> a.GetName().Name = "Expecto") then | |||
| yield Fuchu (Type.GetType("Expecto.AssertException, Expecto")) | |||
|
@neoeinstein Yes I did mean |
|
Super, looking good! |
|
Thanks for the PR! I'll try to get this reviewed, merged, and released ASAP. |
|
Looks great! Merged into master and put in 3.2.0 milestone... gonna try to get this out in next couple days. |
|
FYI - this is released with version 3.2.0 on NuGet now (no foolin'!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not exactly sure, if this is all correct, but it works for me.
I was wondering about, that the VerifyExpectoProject was not really failing without the implementation.