Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spot the Seal #50

Merged
merged 37 commits into from
Aug 30, 2023
Merged

Spot the Seal #50

merged 37 commits into from
Aug 30, 2023

Conversation

nvh
Copy link
Contributor

@nvh nvh commented Aug 30, 2023

Implemented the puzzle hunt

nvh added 30 commits August 30, 2023 02:05
@nvh
Added initial Spot the Seal concept
1a11f04
@nvh
Fix issue with order of navigatio
f8c211f
@nvh
Move destination inside the PuzzlePageView
2c45089
@nvh
Added puzzles to data model
367ccc9
@nvh
Don’t add puzzles in the asset catalog
2b5b885
@nvh
Added decryption of hints
c6859c4
@nvh
Stamping current puzzle when url opened
6fdad5c
@nvh
Improve stamp colors
9f281bb
@nvh
Remove cruft and add comment
87fce5b
@nvh
Hide spot the seal when no seals found
5858145
@nvh
Show checkmark when found solution
fbe84f0
@nvh
Orange seal
f4a5911
@nvh
Store puzzles in the appDataModel
a8e129d
@nvh
Added error when decrypting
0fd4f36
@nvh
Saving and showing hints
5135aa1
@nvh
Fixed recursive navigation
1c06524
@nvh
Add initial hint
9f2e60c
@nvh
Added more puzzles
7f31081
@nvh
Remove unused PDF
f2c5961
@nvh
Add last puzzle
f77c6b3
@nvh
Support dark mode better
8d6b0bb
@nvh
Add tip and answerLength
e8cd3f2
@nvh
Order puzzles
b56cd54
@nvh
Update pdf background based on color scheme
78073ed
@nvh
Reset all
135e757
@nvh
Better colors
dbf1a8b
@nvh
Dark mode support
b8a8bd4
@nvh
Add tint color and move environmentObject to the right place
f1340ef
@nvh
Green checkmark
f302aed
@nvh
Replace button with magic url
8296179
ppeelen
ppeelen approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@ppeelen ppeelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. Just some nit picky comments on whitespaces added.

I am, however, a little concerned about the image sizes. Some PDFs are ~20mb and could be scaled down. The archive size increased from ~70mb to ~200mb. I can imagine that the App Store size also might increase, although not checked.

SwiftIslandApp/Pages/Practical/Spot the Seal/PuzzleItemView.swift Outdated Show resolved Hide resolved
SwiftIslandApp/Utilities/AppDataModel.swift Outdated Show resolved Hide resolved
SwiftIslandApp/MainApp.swift Outdated Show resolved Hide resolved
@nvh
Copy link
Contributor Author

nvh commented Aug 30, 2023

It looks great. Just some nit picky comments on whitespaces added.

I am, however, a little concerned about the image sizes. Some PDFs are ~20mb and could be scaled down. The archive size increased from ~70mb to ~200mb. I can imagine that the App Store size also might increase, although not checked.

Oof, I did not think about that. I don't have the time to make them smaller currently. Let's merge it now, and fix/remove later

@ppeelen
Copy link
Collaborator

ppeelen commented Aug 30, 2023

It looks great. Just some nit picky comments on whitespaces added.
I am, however, a little concerned about the image sizes. Some PDFs are ~20mb and could be scaled down. The archive size increased from ~70mb to ~200mb. I can imagine that the App Store size also might increase, although not checked.

Oof, I did not think about that. I don't have the time to make them smaller currently. Let's merge it now, and fix/remove later

Sounds good.

@nvh nvh merged commit 3029e9a into main Aug 30, 2023
1 check passed
@nvh nvh deleted the feature/spot-the-seal branch August 30, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppeelen ppeelen ppeelen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvh @ppeelen