feat(TopBottomPresentable): Adds 'TopBottomPresentable' protocol, allow any Animator to be presented correctly by the Presenter
#548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
Presenter
check for atopBottomStyle
usingTopBottomAnimation.Style
enum which allow during install to present theMessage
over or undernavigation-bar
andtab-bar
.However the current implementation of the
topBottomStyle
computed property limit all customisation of behaviour and only allow presentation in.top
or.bottom
style with theTopBottomAnimation
animator.I've implemented a simple
TopBottomPresentable
protocol which return theTopBottomAnimation.Style?
behaviour needed; thus we can add conformance of this protocol to our existingTopBottomAnimation
andPhysicsAnimation
.This would allow customisation in any
Animator
in the futur by simple conforming toTopBottomPresentable
.Hope this is convenient for other people as well and can make it in, I'll be available if you need any change or need to drop the last commit (podspecs & version change for my own use atm)