MKPolyline.coordinates and MKPolyline(coordinates:)

[freak4pc]

This PR adds the following two additions:

• A .coordinate property on an instance of MKPolyline, to return a list of coordinates from a provided MKPolyline.

• A init(coordinates:) initializer, to initialize a new MKPolyline from a provided list of coordinates.

[SwifterSwiftBot]

	1 Message
📖	Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

[SD10]

Looks like we'll have to wrap these extensions in #if os(iOS) || os(macOS). We support every platform and it seems to be unsupported on watchOS and tvOS < 9.2

[freak4pc]

I'm not entirely sure why it builds it in watchOS given the fact its not part of that target 🤔

[SD10]

We should also add a new subspec to the Podspec since this is the first MapKit extension:

  # MapKit Extensions
  s.subspec 'MapKit' do |sp|
    sp.source_files  = 'Sources/Extensions/MapKit/*.swift'
  end

[codecov]

Codecov Report

Merging #416 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
+ Coverage   91.01%   91.05%   +0.03%     
==========================================
  Files          56       57       +1     
  Lines        2627     2638      +11     
==========================================
+ Hits         2391     2402      +11     
  Misses        236      236

Flag	Coverage Δ
#ios	91.05% <100%> (+0.03%)	⬆️
#osx	86.61% <100%> (+0.05%)	⬆️
#tvos	86.61% <100%> (+0.05%)	⬆️

Impacted Files	Coverage Δ
...urces/Extensions/MapKit/MKPolylineExtensions.swift	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc1401...cb54069. Read the comment docs.

[freak4pc]

@SD10 Should be good to go now 👍

It's strange to me I need to define a build time rule for watchOS given the fact it's not part of that target but oh well 🤷‍♂️

[freak4pc]

💚

[SD10]

It's strange to me I need to define a build time rule for watchOS given the fact it's not part of that target but oh well 🤷‍♂️

Yeah, to be honest, I completely forgot how we set up all the schemes to support all 4 platforms so I'm unsure as well.

[SD10]

Thanks for the contribution ❤️

[SD10]

Thank you for contributing to SwifterSwift! I've invited you to join the SwifterSwift GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines. Feel free to reach out if you have any questions! 😃