Change recommendation for Alamofire integration #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues with recommending Alamofire-SwiftyJSON: - Not updated for Xcode 6.1. - No longer necessary as a shim to integrate Alamofire and SwiftyJSON. - Adds another dependency that needs to be manually included and managed.
|
@JonathanPorta you're right! But the pr should handle the error from Alamofire. Can you please add some error handling description? |
|
@tangplin I added a simple example where the error object is checked first. I am not sure exactly if this is the best way to check the error. I am still new to Swift. :) |
LukeTangPL
added a commit
that referenced
this pull request
Dec 11, 2014
…n-recomendation Change recommendation for Alamofire integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues with recommending Alamofire-SwiftyJSON:
I feel that recommending a third, separate dependency is confusing and unnecessary to new users. It's only one line to have SwiftyJSON wrap the JSON returned by Alamofire.