Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated Typescript should use namespace keyword rather than module #907

Open
sarod opened this issue Nov 16, 2015 · 2 comments
Open

Generated Typescript should use namespace keyword rather than module #907

sarod opened this issue Nov 16, 2015 · 2 comments

Comments

@sarod
Copy link

sarod commented Nov 16, 2015

When choosing Typescript the generated code uses module keyword that is deprecated it should use namespace instead

See microsoft/TypeScript#2159.
sarod added a commit to sarod/generator-gulp-angular that referenced this issue Nov 16, 2015
@sarod
Generated Typescript should use namespace keyword rather than module
1860a5e 
use namespace instead of module Swiip#907
sarod added a commit to sarod/generator-gulp-angular that referenced this issue Nov 16, 2015
@sarod
Generated Typescript should use namespace keyword rather than module
bce27f1 
Generated Typescript should use namespace keyword rather than module
Swiip#907
@sarod sarod mentioned this issue Nov 16, 2015
Closed
@Swiip
Copy link
Owner

Swiip commented Nov 18, 2015

To be honest, I missed that. I wanted to aligne ES6 and TS for the module handling. Can't we just remove this namespace ? (I'm not a specialist of TS)

@sarod
Copy link
Author

sarod commented Nov 18, 2015

That would probably be better indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Swiip @sarod