feature(xcode12.5): update for a new xcode version and swift 5 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relax94
force-pushed
the
feature/update-project-to-xcode-12-5
branch
from
6db8a6d to
af9d48f
Compare
yoichitgy
reviewed
Jul 2, 2021
| @@ -14,12 +14,12 @@ private var uivcRegistrationNameKey: String = "UIViewController.swinjectRegistra | |||
| private var uivcWasInjectedKey: String = "UIViewController.wasInjected" | |||
|
|
|||
| extension UIViewController: RegistrationNameAssociatable, InjectionVerifiable { | |||
| internal var swinjectRegistrationName: String? { | |||
| public var swinjectRegistrationName: String? { | |||
There was a problem hiding this comment.
It's not sure we really need to make the properties public. We might revert it to internal later.
yoichitgy
reviewed
Jul 2, 2021
| get { return getAssociatedString(key: &uivcRegistrationNameKey) } | ||
| set { setAssociatedString(newValue, key: &uivcRegistrationNameKey) } | ||
| } | ||
|
|
||
| internal var wasInjected: Bool { | ||
| public var wasInjected: Bool { |
There was a problem hiding this comment.
It's not sure we really need to make the properties public. We might revert it to internal later.
|
Thank you for making the script😃 |
yoichitgy
reviewed
Jul 2, 2021
| CLANG_WARN_SUSPICIOUS_MOVE = YES; | ||
| CODE_SIGNING_REQUIRED = NO; | ||
| CURRENT_PROJECT_VERSION = 1; | ||
| GCC_NO_COMMON_BLOCKS = YES; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 8.0; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 12.0; |
There was a problem hiding this comment.
Deployment target was increased. We might revert it later.
yoichitgy
reviewed
Jul 2, 2021
| MACOSX_DEPLOYMENT_TARGET = 10.10; | ||
| MTL_ENABLE_DEBUG_INFO = NO; | ||
| SWIFT_COMPILATION_MODE = wholemodule; | ||
| SWIFT_VERSION = 4.2; | ||
| TARGETED_DEVICE_FAMILY = "1,2"; | ||
| TVOS_DEPLOYMENT_TARGET = 9.0; | ||
| TVOS_DEPLOYMENT_TARGET = 12.0; |
There was a problem hiding this comment.
Deployment target was increased. We might revert it later.
yoichitgy
reviewed
Jul 2, 2021
| @@ -1138,7 +1140,7 @@ | |||
| "$(PROJECT_DIR)/Carthage/Build/iOS", | |||
| ); | |||
| INFOPLIST_FILE = Tests/Info.plist; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 9.0; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 12.0; | |||
There was a problem hiding this comment.
Deployment target was increased. We might revert it later.
yoichitgy
reviewed
Jul 2, 2021
| @@ -1155,7 +1157,7 @@ | |||
| "$(PROJECT_DIR)/Carthage/Build/iOS", | |||
| ); | |||
| INFOPLIST_FILE = Tests/Info.plist; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 9.0; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 12.0; | |||
There was a problem hiding this comment.
Deployment target was increased. We might revert it later.
This was referenced Jul 2, 2021
yoichitgy
added a commit
to yoichitgy/SwinjectStoryboard
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.