Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 4.6.2 target #195

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Add .NET 4.6.2 target #195

merged 2 commits into from
Jan 17, 2024

Conversation

fgreinacher
Copy link
Contributor

NUnit 4 does not support .NET Standard 2.0 anymore,
so we need to stay on NUnit 3 when targeting .NET Standard.

This commit adds a dedicated .NET 4.6.2 target that uses NUnit 4.

Addresses #194

@swisslife-bot
Copy link
Contributor

swisslife-bot commented Jan 9, 2024

CLA assistant check
All committers have signed the CLA.

NUnit 4 does not support .NET Standard 2.0 anymore,
so we need to stay on NUnit 3 when targeting .NET Standard.

This commit adds a dedicated .NET 4.6.2 target that uses NUnit 4.
@fgreinacher fgreinacher changed the title Fix/net462 Add .NET 4.6.2 target Jan 9, 2024
@fgreinacher fgreinacher marked this pull request as ready for review January 9, 2024 08:56
@RohrerF
Copy link
Member

RohrerF commented Jan 12, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@RohrerF RohrerF merged commit 94f9c77 into SwissLife-OSS:master Jan 17, 2024
3 checks passed
@fgreinacher fgreinacher deleted the fix/net462 branch January 17, 2024 14:46
@fgreinacher
Copy link
Contributor Author

This worked out well, thanks for merging!

dylan-apollo referenced this pull request in apollographql/subgraph-csharp-hotchocolate-annotation Jul 10, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [Snapshooter.Xunit](https://github.com/SwissLife-OSS/Snapshooter) |
`0.13.0` -> `0.14.1` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Snapshooter.Xunit/0.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Snapshooter.Xunit/0.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Snapshooter.Xunit/0.13.0/0.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Snapshooter.Xunit/0.13.0/0.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>SwissLife-OSS/Snapshooter (Snapshooter.Xunit)</summary>

###
[`v0.14.1`](https://github.com/SwissLife-OSS/snapshooter/releases/tag/0.14.1)

[Compare
Source](https://github.com/SwissLife-OSS/Snapshooter/compare/0.14.0...0.14.1)

##### What's Changed

- Add .NET 4.6.2 target by
[@&#8203;fgreinacher](https://github.com/fgreinacher) in
[https://github.com/SwissLife-OSS/snapshooter/pull/195](https://github.com/SwissLife-OSS/snapshooter/pull/195)

##### New Contributors

- [@&#8203;fgreinacher](https://github.com/fgreinacher) made their
first contribution in
[https://github.com/SwissLife-OSS/snapshooter/pull/195](https://github.com/SwissLife-OSS/snapshooter/pull/195)

**Full Changelog**:
SwissLife-OSS/snapshooter@0.14.0...0.14.1

###
[`v0.14.0`](https://github.com/SwissLife-OSS/snapshooter/releases/tag/0.14.0)

[Compare
Source](https://github.com/SwissLife-OSS/Snapshooter/compare/0.13.0...0.14.0)

##### What's Changed

- Added support for .NET 8, NUnit 4.0 by
[@&#8203;daghsentinel](https://github.com/daghsentinel) in
[https://github.com/SwissLife-OSS/snapshooter/pull/188](https://github.com/SwissLife-OSS/snapshooter/pull/188)
-   drop support for EOL net3.1

##### New Contributors

- [@&#8203;daghsentinel](https://github.com/daghsentinel) made their
first contribution in
[https://github.com/SwissLife-OSS/snapshooter/pull/188](https://github.com/SwissLife-OSS/snapshooter/pull/188)

**Full Changelog**:
SwissLife-OSS/snapshooter@0.13.0...0.14.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/apollographql/subgraph-csharp-hotchocolate-annotation).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants