Skip to content
This repository has been archived by the owner on Jan 19, 2025. It is now read-only.

"Is it up?" command #117

Merged
merged 5 commits into from
Jun 22, 2018
Merged

"Is it up?" command #117

merged 5 commits into from
Jun 22, 2018

Conversation

pedrofracassi
Copy link
Member

New stuff

s!isitup <address> - Checks if a website is online

(did it in less than 30min and got no errors yeeeee)

Closes #106

@pedrofracassi pedrofracassi added the scope: commands New command(s) suggestion/addition label Jun 17, 2018
@Doges
Copy link
Member

Doges commented Jun 17, 2018

@pedrofracassi fix your shit

# Conflicts:
#	src/locales/en-US/commands.json
@pedrofracassi
Copy link
Member Author

@Doges @bolsomito plz review

Doges
Doges previously approved these changes Jun 20, 2018
Copy link
Member

@Doges Doges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

async run (message, args, t) {
const embed = new SwitchbladeEmbed(message.author)
if (args.length > 0) {
message.channel.startTyping()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put this in between the embed constant n' the if case


async run (message, args, t) {
const embed = new SwitchbladeEmbed(message.author)
if (args.length > 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and using args.length isn't necessary, you could just use CommandParameters

@pedrofracassi
Copy link
Member Author

image

jaxxibae
jaxxibae previously approved these changes Jun 22, 2018
Copy link
Member

@jaxxibae jaxxibae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaxxibae jaxxibae self-requested a review June 22, 2018 01:37
Copy link
Member

@jaxxibae jaxxibae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaaaaaaaaaaaaaaaaaaaaaa

Copy link
Member

@Doges Doges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Doges Doges merged commit 0d9322b into master Jun 22, 2018
@Doges Doges deleted the isitup-command branch June 22, 2018 01:38
@jaxxibae jaxxibae restored the isitup-command branch June 22, 2018 01:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: commands New command(s) suggestion/addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants