fix: update x/mint parameter validation (backport cosmos#12384) (cosm…

…os#12396)
Switcheo · Aug 10, 2022 · e3bf809 · e3bf809
1 parent b3b1ec6
commit e3bf809
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -37,6 +37,10 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ## [Unreleased]
 
+### Bug Fixes
+
+* (x/mint) [#12384](https://github.com/cosmos/cosmos-sdk/pull/12384) Ensure `GoalBonded` must be positive when performing `x/mint` parameter validation.
+
 ## [v0.45.6](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.45.6) - 2022-06-28
 
 ### Improvements

diff --git a/x/mint/types/params.go b/x/mint/types/params.go
@@ -171,8 +171,8 @@ func validateGoalBonded(i interface{}) error {
 		return fmt.Errorf("invalid parameter type: %T", i)
 	}
 
-	if v.IsNegative() {
-		return fmt.Errorf("goal bonded cannot be negative: %s", v)
+	if v.IsNegative() || v.IsZero() {
+		return fmt.Errorf("goal bonded must be positive: %s", v)
 	}
 	if v.GT(sdk.OneDec()) {
 		return fmt.Errorf("goal bonded too large: %s", v)