V0.50.1 patched #438
Closed
V0.50.1 patched #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reverting msgmultisend is not safe |
RavenXce
requested changes
Jan 8, 2024
| @@ -572,9 +578,9 @@ func (mr *MockBankKeeperMockRecorder) InitGenesis(arg0, arg1 interface{}) *gomoc | |||
| } | |||
|
|
|||
| // InputOutputCoins mocks base method. | |||
| func (m *MockBankKeeper) InputOutputCoins(ctx context.Context, input types0.Input, outputs []types0.Output) error { | |||
| func (m *MockBankKeeper) InputOutputCoins(ctx context.Context, inputs []types0.Input, outputs []types0.Output) error { | |||
| @@ -136,6 +140,9 @@ swagger = {{ .API.Swagger }} | |||
| # Address defines the API server to listen on. | |||
| address = "{{ .API.Address }}" | |||
|
|
|||
| # Oracle-address defines the API server to listen on for oracle service. | |||
| oracle-address = "{{ .API.OracleAddress }}" | |||
| }, | ||
| API: APIConfig{ | ||
| Enable: false, | ||
| Swagger: false, | ||
| Address: DefaultAPIAddress, | ||
| OracleAddress: DefaultOracleAPIAddress, |
| @@ -108,6 +111,9 @@ type APIConfig struct { | |||
| // Address defines the API server to listen on | |||
| Address string `mapstructure:"address"` | |||
|
|
|||
| // OracleAddress defines if the API server to listen on for oracle service | |||
| OracleAddress string `mapstructure:"oracle-address"` | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key changes:
multiSendcan only have one sender (Make MsgMultiSend single sender cosmos/cosmos-sdk#12601)sendandmultiSendtypeAsserts the bank keeper to be of typeBaseKeeper(this type assertion has issues with our implementation as our bank keeper is customised due to the x/alliance module, where the keeper is a wrapper of the originalx/bank BaseKeeper, resulting in the type assertion check failing102b3f2