feat: android target #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syer10
requested changes
Jan 16, 2024
Comment on lines
16
to
23
| private var _Context: WeakReference<Context>? = null | ||
| internal val ContextRef: Context get() { | ||
| return _Context?.get() ?: throw AppDirsException("In android target, please call Application#attachAppDirs() first!") | ||
| } | ||
|
|
||
| fun Application.attachAppDirs() { | ||
| _Context = WeakReference(this) | ||
| } |
There was a problem hiding this comment.
Well done! This is the main thing I was worried about when thinking of how to implement a Android target. This seems like a good solution
sgpublic
commented
Jan 17, 2024
| @@ -28,6 +25,14 @@ kotlin { | |||
| linuxArm64() | |||
| mingwX64() | |||
|
|
|||
| androidTarget { | |||
| publishLibraryVariants("release") | |||
There was a problem hiding this comment.
By the way, the reason for adding this line is a bug from gradle-maven-publish-plugin
|
@Syer10 Can you merge this nice PR? |
|
Thanks! Its included in the latest release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, first of all thank you for your great work on Kotlin-Multiplatform-AppDirs.
Currently AppDir has completed all desktop targets. It would be great if the android target could be added. I have completed the Android target in my fork, so I created this PR.
Thank you!