Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product pagination bug #9699

Closed
mikemix opened this issue Sep 10, 2018 · 3 comments
Closed

Product pagination bug #9699

mikemix opened this issue Sep 10, 2018 · 3 comments
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced. Shop ShopBundle related issues and PRs.

Comments

@mikemix
Copy link
Contributor

mikemix commented Sep 10, 2018 •
edited
Loading

Sylius version affected: every

Description
https://demo.sylius.com/en_US/taxons/t-shirts So we request 9 products per page, but only 6 are visible, the others are on the second page. My guess is this should not happen.

Steps to reproduce
Visit https://demo.sylius.com/en_US/taxons/t-shirts

Possible Solution
Dunno.
@mikemix mikemix changed the title Product pagination issue Product pagination bug? Sep 12, 2018
@mikemix mikemix changed the title Product pagination bug? Product pagination bug Sep 21, 2018
@CoderMaggie CoderMaggie added Potential Bug Potential bugs or bugfixes, that needs to be reproduced. Shop ShopBundle related issues and PRs. labels Oct 2, 2018
@mikemix
Copy link
Contributor Author

mikemix commented Oct 30, 2018

This is a major issue in my opinion.

@bartoszpietrzak1994 bartoszpietrzak1994 mentioned this issue Nov 12, 2018
Closed
laurent35240 added a commit to laurent35240/Sylius that referenced this issue Jan 5, 2019
@laurent35240
Sylius#9699 Fix for viewing products when they belong to a taxon and …
9c02892 
…to one of children taxon
@laurent35240 laurent35240 mentioned this issue Jan 5, 2019
Merged
laurent35240 added a commit to laurent35240/Sylius that referenced this issue Jan 5, 2019
@laurent35240
Sylius#9699 Fix for viewing products when they belong to a taxon and…
94b8a15 
… to one of children taxon
laurent35240 added a commit to laurent35240/Sylius that referenced this issue Jan 13, 2019
@laurent35240
Sylius#9699 🍌 -> 🥥
954dbdd
pamil added a commit that referenced this issue Jan 13, 2019
@pamil
Merge branch '1.2' into 1.3
82fab5a 
* 1.2:
  Apply coding standard fixes
  #9699 🍌 -> 🥥
  Revert int strictness to just pass strings
  Make tests passing
  Fix build
  Behat test for assigning main taxon on new product
  #9699 Fix for viewing products when they belong to a taxon and to one of children taxon
@pamil pamil closed this as completed in ce290b0 Jan 13, 2019
pamil added a commit that referenced this issue Jan 13, 2019
@pamil
Merge branch '1.3'
2bdd2a9 
* 1.3:
  Apply coding standard fixes
  Apply coding standard fixes
  #9699 🍌 -> 🥥
  Revert int strictness to just pass strings
  Make tests passing
  Fix build
  Behat test for assigning main taxon on new product
  #9699 Fix for viewing products when they belong to a taxon and to one of children taxon
@vvasiloi
Copy link
Contributor

It's happening again: https://demo.sylius.com/en_US/taxons/t-shirts?limit=9
image

@smashou
Copy link

smashou commented Apr 29, 2019 •
edited
Loading

I think it comes from the ->addSelect('productTaxon') in the ProductRepository > createShopListQueryBuilder. I suppose it is there to decrease the number of SQL requests, but it also generate duplicate results if a product is linked to many Taxons.

@vvasiloi vvasiloi mentioned this issue Apr 29, 2019
Closed
pamil added a commit to pamil/Sylius that referenced this issue May 7, 2019
@pamil
Merge branch '1.3'
17735a7 
* 1.3:
  Apply coding standard fixes
  Apply coding standard fixes
  Sylius#9699 🍌 -> 🥥
  Revert int strictness to just pass strings
  Make tests passing
  Fix build
  Behat test for assigning main taxon on new product
  Sylius#9699 Fix for viewing products when they belong to a taxon and to one of children taxon
pamil added a commit to pamil/Sylius that referenced this issue May 7, 2019
@pamil
Merge branch '1.3'
14fc4b6 
* 1.3:
  Apply coding standard fixes
  Apply coding standard fixes
  Sylius#9699 🍌 -> 🥥
  Revert int strictness to just pass strings
  Make tests passing
  Fix build
  Behat test for assigning main taxon on new product
  Sylius#9699 Fix for viewing products when they belong to a taxon and to one of children taxon
@vvasiloi vvasiloi mentioned this issue Jun 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced. Shop ShopBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smashou @mikemix @vvasiloi @CoderMaggie