[Behat] Changing my account password with token I received scenario #9742
Conversation
loic425
changed the title
| private function prepareUserPasswordResetToken(UserInterface $user) | ||
| { | ||
| $token = 'itotallyforgotmypassword'; | ||
| $this->sharedStorage->set('password_reset_token', $token); |
There was a problem hiding this comment.
I think we don't need shared storage here if in When I follow link on my email to reset my password step we would get the User model and take the password reset token from there.
There was a problem hiding this comment.
Do we keep this following code with storage on setup context ?
$this->sharedStorage->set('password_reset_token', $token);There was a problem hiding this comment.
I think it's no longer needed then.
| use Behat\Mink\Exception\ElementNotFoundException; | ||
| use Sylius\Behat\Page\SymfonyPage; | ||
|
|
||
| class RequestPasswordRequestResetPage extends SymfonyPage implements RequestPasswordResetPageInterface |
There was a problem hiding this comment.
There's a doubled Request in the class name, shouldn't it be RequestPasswordResetPage (esp. because of the interface name)?
There was a problem hiding this comment.
Lol yeah, it's a mistake :)
| * | ||
| * @return bool | ||
| */ | ||
| public function checkValidationMessageFor($element, $message); |
There was a problem hiding this comment.
We can use typehints both for arguments and the return value in this interface.
|
Thank you, Loic! 🥇 🎉 |
I've changed a behat page and its interface cause I've renamed an existing one... If you have a better idea, I'm opened. But the old name was confusing with missing one.