Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header-only #38

Open
2 tasks
SymbolixAU opened this issue Sep 28, 2018 · 2 comments
Open
2 tasks

header-only #38

SymbolixAU opened this issue Sep 28, 2018 · 2 comments
Milestone

Comments

@SymbolixAU
Copy link
Collaborator

SymbolixAU commented Sep 28, 2018

restructure everything

TODO

@SymbolixAU SymbolixAU self-assigned this Sep 28, 2018
@SymbolixAU SymbolixAU added this to the v0.7.2 milestone Sep 28, 2018
@SymbolixAU
Copy link
Collaborator Author

SymbolixAU commented Sep 29, 2018

Progress

library(microbenchmark)

microbenchmark(
  r = { googlePolylines:::geometryRow.sfencoded( e, "POLYGON", multi = T) },
  rcpp = { googlePolylines:::rcpp_get_geometry_types( e$geometry, "MULTIPOLYGON") },
  rcpp_mult = { googlePolylines:::rcpp_get_geometry_types_multi( e$geometry, "POLYGON", "MULTIPOLYGON") }
)

# Unit: microseconds
#      expr     min       lq      mean   median       uq      max neval
#         r 482.355 493.4985 603.21041 505.5890 555.5125 2831.437   100
#      rcpp  44.740  46.9655  65.92212  49.3310  57.4835  487.616   100
# rcpp_mult  46.289  48.6280  59.73938  51.6655  57.9990  304.934   100

@SymbolixAU SymbolixAU modified the milestones: v0.7.2, v0.7.3 Nov 22, 2018
dcooley added a commit to dcooley/googlePolylines that referenced this issue Feb 8, 2020
@dcooley
Copy link
Collaborator

dcooley commented Feb 9, 2020

This branch is currently slower than the master implementation for MULTIPOLYGONs. Other geometries seem fine.

@SymbolixAU SymbolixAU changed the title header-only encode header-only Apr 3, 2020
SymbolixAU pushed a commit that referenced this issue Apr 3, 2020
dcooley added a commit that referenced this issue Apr 3, 2020
@SymbolixAU SymbolixAU removed their assignment Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant