Skip to content

Commit

Permalink
feature #2 Cleanup and windows (weaverryan)
Browse files Browse the repository at this point in the history
This PR was squashed before being merged into the main branch.

Discussion
----------

Cleanup and windows

Hi!

3 things:

1) Remove the different test suites from being run independently. I don't see a lot of value to this and it meant that I was accidentally running NO tests for TailwindBundle, since I didn't have the testsuites config. So I'd like to simplify.

2) Removed what I believe is an unused `phpunit` input

3) Make `runs-on` dynamic so the job could be re-used for windows.

Here is a PR using this new setup: SymfonyCasts/tailwind-bundle#4

Commits
-------

41fe3e7 Cleanup and windows
  • Loading branch information
weaverryan committed Jun 28, 2023
2 parents 65f935c + 41fe3e7 commit f21472b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 15 deletions.
21 changes: 6 additions & 15 deletions .github/workflows/phpunit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ on:
required: false
default: 7.2.5
type: string
phpunit:
description: PHPUnit script (phpunit/simple-phpunit)
runs-on:
description: The "runs-on" platform config
required: false
default: phpunit
default: 'ubuntu-latest'
type: string

jobs:
phpunit:
name: PHP ${{ matrix.php-version }}, ${{ matrix.dependency-versions }} deps, ${{ matrix.composer-options }}
runs-on: ubuntu-latest
runs-on: ${{ inputs.runs-on }}

strategy:
fail-fast: false
Expand Down Expand Up @@ -58,14 +58,5 @@ jobs:
dependency-versions: ${{ matrix.dependency-versions }}
composer-options: ${{ matrix.composer-options }} --prefer-dist

- name: Unit Tests
run: vendor/bin/simple-phpunit -c $GITHUB_WORKSPACE/phpunit.xml.dist --testsuite unit

- name: Functional Tests
run: vendor/bin/simple-phpunit -c $GITHUB_WORKSPACE/phpunit.xml.dist --testsuite functional

- name: Integration Tests
run: vendor/bin/simple-phpunit -c $GITHUB_WORKSPACE/phpunit.xml.dist --testsuite integration

- name: Acceptance Tests
run: vendor/bin/simple-phpunit -c $GITHUB_WORKSPACE/phpunit.xml.dist --testsuite acceptance
- name: Tests
run: vendor/bin/simple-phpunit
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ The list of repositories that are dependent on this repo:
- [symfonycasts/reset-password-bundle](https://github.com/SymfonyCasts/reset-password-bundle)
- [symfonycasts/verify-email-bundle](https://github.com/SymfonyCasts/verify-email-bundle)
- [symfonycasts/messenger-monitor-bundle](https://github.com/SymfonyCasts/messenger-monitor-bundle)
- [symfonycasts/tailwind-bundle](https://github.com/SymfonyCasts/tailwind-bundle)

0 comments on commit f21472b

Please sign in to comment.