Allowing a custom config_file relative to the project #30
Conversation
Update TailwindInitCommand.php
Update services.php
Update index.rst
Update TailwindBuilder.php
|
@bocharsky-bw i resolved all issues the ci tool identified. is there anything else for me to do? 🙂 |
There was a problem hiding this comment.
Hey, thanks for sending this PR! I left some comments
Also, I see you make this config path configurable... but I wonder what use case is behind of this feature? IMO hardcoded Tailwind CSS config file in the root folder is kind of standard makes things simpler, no? I mean, could you describe your specific use case better, where are you keeping your config file and why not in the project root?
src/TailwindBuilder.php
Outdated
| @@ -28,6 +28,7 @@ class TailwindBuilder | |||
| public function __construct( | |||
| private readonly string $projectRootDir, | |||
| string $inputPath, | |||
| private readonly string $configPath, | |||
There was a problem hiding this comment.
It looks like a BC break. I think if we will add it to the end and give it a default value - we will be able to avoid BC breaks
Hi @bocharsky-bw thanks for your reply. The ability to configure the path of the configuration file makes it possible to deliver the configuration in an encapsulated bundle. I have a Shopware6 project based on Symfony and have created a bundle for a custom theme. Each theme is a separate bundle, hence the requirement. |
Co-authored-by: Victor Bocharsky <bocharsky.bw@gmail.com>
|
Hey @barbieswimcrew , Sorry for the delay on this! It seems like this now has merge conflicts... sorry about it too! Could you fix them to move it forward? |
Hey @bocharsky-bw no worries! Updated the pr... let me know if I can help in any way :-) |
This PR allows one to set a custom path to the tailwind.config.js