Windows Docker and Tailwind watch mode #57
Conversation
There was a problem hiding this comment.
I think we should repeat the same behavior like Tailwind does, i.e. --watch and --poll should be 2 separate options. IMO it would be better UX. You try the --watch first which will work in most cases, but if somehow it's not working for you - add that extra --poll option. First if all, it will be the same way as it's implemented upstream in Tailwind, so it will be intuitive, and second - it will avoid duplicating --watch when you run the command with --watch --pollWatch at the same time.
Could you refactor this please?
| bool $minify, | ||
| ): Process { | ||
| $binary = $this->createBinary(); | ||
| $arguments = ['-c', $this->configPath, '-i', $this->inputPath, '-o', $this->getInternalOutputCssPath()]; | ||
| if ($watch) { | ||
| $arguments[] = '--watch'; | ||
| if ($poll) { | ||
| $arguments[] = '--poll'; | ||
| } |
There was a problem hiding this comment.
Can't we use --poll without --watch? I see these fields are probably dependent, but this implementation will just silently not add --poll if no --watch was passed to the final command. But probably that's not a problem, because if you don't pass --watch then it's just finish the execution and that's it, so probably that's not a big deal to have this nested ot the --watch.
Just curious about your opinion on it
There was a problem hiding this comment.
In my opinion, it should not be possible to use the --poll option if the --watch option is not called, maybe we should throw an exception if this case happens ?
There was a problem hiding this comment.
Hm, that's not something that Tailwind does, so I think it's safe to merge it as is.
Thanks again!
Co-authored-by: Victor Bocharsky <bocharsky.bw@gmail.com>
Closes #56