Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix randomly failed tests on Windows v2 #75

Merged
merged 12 commits into from
Oct 31, 2024
Merged

[CI] Fix randomly failed tests on Windows v2 #75

Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e71c418
Try to fix randomly failed tests by removing the dir in tearDown()
bocharsky-bw Oct 30, 2024
867b682
Try catch the exception and try again in a second
bocharsky-bw Oct 30, 2024
0f543be
Rebuild CI
bocharsky-bw Oct 30, 2024
f51b569
Improve the warning message
bocharsky-bw Oct 30, 2024
e829b35
Don't need to check if dir exist - it always should be created
bocharsky-bw Oct 30, 2024
a723b10
Drop the whole dir w/o pre-deleting files one by one
bocharsky-bw Oct 30, 2024
0649fc9
Revert "Drop the whole dir w/o pre-deleting files one by one"
bocharsky-bw Oct 30, 2024
77e9587
use filesystem->remove() instead of unlink()
bocharsky-bw Oct 30, 2024
3aa265c
Try to delete the folder in a loop during 5 seconds
bocharsky-bw Oct 30, 2024
8b81384
Just remove the dir with files
bocharsky-bw Oct 30, 2024
a6b164e
Remove pointless addWarning() in tearDown() and simplify logic
bocharsky-bw Oct 31, 2024
d6e5ddc
Drop temporary files that were committed
bocharsky-bw Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions tests/TailwindBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

use PHPUnit\Framework\TestCase;
use Symfony\Component\Cache\Adapter\ArrayAdapter;
use Symfony\Component\Filesystem\Exception\IOException;
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Finder\Finder;
use Symfonycasts\TailwindBundle\TailwindBuilder;
Expand All @@ -20,9 +21,6 @@ class TailwindBuilderTest extends TestCase
protected function setUp(): void
{
$fs = new Filesystem();
if (file_exists(__DIR__.'/fixtures/var/tailwind')) {
$fs->remove(__DIR__.'/fixtures/var/tailwind');
}
$fs->mkdir(__DIR__.'/fixtures/var/tailwind');
}

Expand All @@ -33,6 +31,18 @@ protected function tearDown(): void
foreach ($finder as $file) {
unlink($file->getRealPath());
}
$fs = new Filesystem();
if (file_exists(__DIR__.'/fixtures/var/tailwind')) {
kbond marked this conversation as resolved.
Show resolved Hide resolved
try {
$fs->remove(__DIR__.'/fixtures/var/tailwind');
} catch (IOException $e) {
// Sometimes "Permission denied" error happens on Windows,
// add a warning about it and try again in a second
$this->addWarning('Could not remove the temporary tailwind/ dir (trying again in 1 second): '.$e->getMessage());
sleep(1);
$fs->remove(__DIR__.'/fixtures/var/tailwind');
}
}
}

public function testIntegrationWithDefaultOptions(): void
Expand Down
Loading