Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using custom PostCSS configuration file #80

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Allow using custom PostCSS configuration file #80

merged 5 commits into from
Jan 22, 2025

Conversation

fracsi
Copy link
Contributor

@fracsi fracsi commented Jan 9, 2025

See #79

fracsi added 4 commits January 8, 2025 22:29
@fracsi
PostCss option
b726059 
Add tailwind cli postcss option to the build command
@fracsi
PostCSS config file to config
fe08220 
Test added
Documentation added
@fracsi
Documentation fix
28550d5
@fracsi
Reformat services.php
85c123c
bocharsky-bw
bocharsky-bw reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, if both postcss_config_file and --postcss option are specified at the same time but with different paths, what will win? Does --postcss option override postcss_config_file?

src/TailwindBuilder.php Outdated Show resolved Hide resolved
src/TailwindBuilder.php Outdated Show resolved Hide resolved
@fracsi
Copy link
Contributor Author

fracsi commented Jan 17, 2025

To clarify, if both postcss_config_file and --postcss option are specified at the same time but with different paths, what will win? Does --postcss option override postcss_config_file?

Yes - just like the input.

@fracsi @bocharsky-bw
Consistent naming
dd7d906 
Co-Authored-By: Victor Bocharsky <bocharsky.bw@gmail.com>
bocharsky-bw
bocharsky-bw approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

@kbond kbond merged commit 5c0e366 into SymfonyCasts:main Jan 22, 2025
12 checks passed
@kbond kbond mentioned this pull request Jan 22, 2025
Closed
@kbond
Copy link
Contributor

kbond commented Jan 22, 2025

Thanks @fracsi, great work!

@fracsi fracsi deleted the postcss branch January 22, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fracsi @kbond @bocharsky-bw