File format to extension function

[mohitdmak]

Hey @tcmitchell @jakebeal , this tries to fix #244 , by implementing a function bound on the Document class to provide standard extensions for given file format.

[tcmitchell]

This looks great. I made a couple of suggestions to improve the code. I'd also like to see a unit tests that checks at least 2 of the known file types and one unknown file type, verifying the raised exception.

There are unit tests that check for exceptions. Let me know if you can't find one. I would be happy to help you craft some or all of this test method. It should go in test_document.py.

Thanks!

[tcmitchell]

Let's remove this comment line and put it into a docstring (see below):

Suggested change

# Return standard extensions when provided the document's file format

[tcmitchell]

Let's make this a staticmethod since it doesn't use self, and add a docstring:

Suggested change

	def file_extension(self, file_format: str) -> str:
	@staticmethod
	def file_extension(file_format: str) -> str:
	"""Return standard extensions when provided the document's file format
	:param file_format: The format of the file
	:return: A file extension, including the leading '.'
	"""

[mohitdmak]

This looks great. I made a couple of suggestions to improve the code. I'd also like to see a unit tests that checks at least 2 of the known file types and one unknown file type, verifying the raised exception.
There are unit tests that check for exceptions. Let me know if you can't find one. I would be happy to help you craft some or all of this test method. It should go in test_document.py.

Sure, I have made one named test_file_extension in test_document.py.